xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: Automatic build dependency calculations

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: Automatic build dependency calculations
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 24 Jan 2010 18:17:52 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100121112426.GB27634@xxxxxxxxxxxxx>
References: <1264053773-6054-1-git-send-email-david@xxxxxxxxxxxxx> <1264053773-6054-3-git-send-email-david@xxxxxxxxxxxxx> <20100121112426.GB27634@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jan 21, 2010 at 06:24:26AM -0500, Christoph Hellwig wrote:
> >  LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize \
> > -   preallo_rw_pattern_reader preallo_rw_pattern_writer ftrunc trunc \
> > -   fs_perms testx looptest locktest unwritten_mmap \
> > +   ftrunc trunc fs_perms testx looptest locktest unwritten_mmap \
> >     bulkstat_unlink_test bulkstat_unlink_test_modified t_dir_offset \
> >     t_futimens
> >  
> > +SUBDIRS =
> > +
> >  LLDLIBS = $(LIBATTR) $(LIBHANDLE) $(LIBACL)
> >  
> >  ifeq ($(HAVE_XLOG_ASSIGN_LSN), true)
> > @@ -27,6 +28,7 @@ endif
> >  IRIX_TARGETS = open_unlink
> >  
> >  ifeq ($(PKG_PLATFORM),linux)
> > +PREALLO_TARGETS = preallo_rw_pattern_reader
> 
> What happens to the writer here?

Oops, missed it.
>
> Before introducing more special cases
> for this duplicates let me post my patch to make the file compiled more
> normal, will send it out ASAP.

OK, I'll pull your patch into my series and rebase my change on it
before pushing the lot of them.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>