xfs
[Top] [All Lists]

RE: [PATCH] xfstests: fix format string warnings in locktest.c

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: RE: [PATCH] xfstests: fix format string warnings in locktest.c
From: "Alex Elder" <aelder@xxxxxxx>
Date: Thu, 21 Jan 2010 11:50:17 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20100121173237.GA25322@xxxxxxxxxxxxx>
Thread-index: Acqav7y3s608mbucTleoAK6Mz+xSyQAAlh0w
Thread-topic: [PATCH] xfstests: fix format string warnings in locktest.c
Christoph Hellwig wrote:
> On Thu, Jan 21, 2010 at 10:34:12AM -0600, Alex Elder wrote:
>> Alex Elder wrote:
>>> Christoph Hellwig wrote:
>>>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>>> 
>>> Looks good.
>>> 
>>> Reviewed-by: Alex Elder <aelder@xxxxxxx>
>> 
>> By the way, the content of this patch is already incorporated
>> in Dave's patch "[7/8] xfstests: fix printf warnings in loctest.c".
>> http://patchwork.xfs.org/patch/517/
> 
> Dave fixed the warnings not quite correctly, he switched from %d which
> was totally wrong to %lu which is only correct on some 64-bit
> architectures.  %zd is the really correct format.

Ah, yes, you are correct.  So the right fix is a combination
of the two patches.  All I noticed was that when I tried to
apply your patch on top of Dave's it didn't work...

Thanks.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>