Alex Elder wrote:
> Christoph Hellwig wrote:
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> Looks good.
>
> Reviewed-by: Alex Elder <aelder@xxxxxxx>
By the way, the content of this patch is already incorporated
in Dave's patch "[7/8] xfstests: fix printf warnings in loctest.c".
http://patchwork.xfs.org/patch/517/
>> Index: xfstests-dev/src/locktest.c
>> ===================================================================
>> --- xfstests-dev.orig/src/locktest.c 2010-01-21 11:26:53.000000000 +0000
>> +++ xfstests-dev/src/locktest.c 2010-01-21 11:27:13.000000000 +0000
>> @@ -741,7 +741,7 @@ send_ctl(void)
>> if (nwrite < 0)
>> perror("send_ctl: write");
>> else
>> - fprintf(stderr, "send_ctl[%d]: write() returns %d, not %lu as
>> expected\n",
>> + fprintf(stderr, "send_ctl[%d]: write() returns %d, not %zu as
>> expected\n",
>> ctl.test, nwrite, sizeof(ctl)); exit(1);
>> /*NOTREACHED*/
>> @@ -756,7 +756,7 @@ void recv_ctl(void)
>> if (nread < 0)
>> perror("recv_ctl: read");
>> else {
>> - fprintf(stderr, "recv_ctl[%d]: read() returns %d, not %lu as
>> expected\n",
>> + fprintf(stderr, "recv_ctl[%d]: read() returns %d, not %zu as
>> expected\n",
>> ctl.test, nread, sizeof(ctl));
>> fprintf(stderr, "socket might has been closed by other
>> locktest\n"); }
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@xxxxxxxxxxx
>> http://oss.sgi.com/mailman/listinfo/xfs
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
|