[Top] [All Lists]

Re: [PATCH 1/2] xfstests: rebuild aclocal.m4

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfstests: rebuild aclocal.m4
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 21 Jan 2010 06:21:15 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1264053773-6054-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1264053773-6054-1-git-send-email-david@xxxxxxxxxxxxx> <1264053773-6054-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Jan 21, 2010 at 05:02:52PM +1100, Dave Chinner wrote:
> The local m4 configuration has not been built in a long time.
> Trying to rebuild it results in failures with dmapi library
> detection and libxfs.h detection macros. Fix the errors and rebuild
> it.
> Note: the new format for the aclocal.m4 file uses m4_include
> directives which means it is much smaller th an before and won't
> need updating unless we include new m4 macro files.

Looks good, but shouldn't we create aclocal.m4 automocatically as part
of make configure which generates the rest of the auto* stuff and stop
having it checked into the git repository?

<Prev in Thread] Current Thread [Next in Thread>