xfs
[Top] [All Lists]

Re: Obsolete config in kernel build system (XFS_TRACE)

To: Christoph Egger <siccegge@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: Obsolete config in kernel build system (XFS_TRACE)
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 21 Jan 2010 09:46:26 +1100
Cc: linux-kernel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, Reinhard.Tartler@xxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20100120125249.GC3580@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20100120125249.GC3580@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Jan 20, 2010 at 01:52:49PM +0100, Christoph Egger wrote:
> Hi all!
> 
>       As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
>       Git commit 0b1b213fcf3a8486ada99a2bab84ab8c6f51b264 by
> Christoph Hellwig removed all References to CONFIG_XFS_TRACE, which is
> unreferenced from KConfig side from the linux source code so there's
> only a small bit of it left in KBuild. Mayee remove it as well?
> 
> ./fs/xfs/Makefile:95
> +++>
> 
> xfs-$(CONFIG_XFS_TRACE)         += xfs_btree_trace.o
> 
> <+++
> 
>       Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.

Christoph's conversion to use the kernel trace infrastructure is
a work in progress. It's no small task - he's converted around 220
trace points points so far.

However, the btree tracing code has not been converted yet. IIRC
this is because the kernel trace code didn't have the required
infrastructure at the time of initial conversion. Hence the old code
has not yet been completely removed because the conversion is not
yet complete.  It will go away when the conversion is completed.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>