xfs
[Top] [All Lists]

Re: Obsolete config in kernel build system (XFS_TRACE)

To: Christoph Egger <siccegge@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: Obsolete config in kernel build system (XFS_TRACE)
From: "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx>
Date: Wed, 20 Jan 2010 07:57:23 -0500 (EST)
Cc: linux-kernel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, Reinhard.Tartler@xxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20100120125249.GC3580@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20100120125249.GC3580@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Wed, 20 Jan 2010, Christoph Egger wrote:

> Hi all!
>
>       As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
>       Git commit 0b1b213fcf3a8486ada99a2bab84ab8c6f51b264 by
> Christoph Hellwig removed all References to CONFIG_XFS_TRACE, which is
> unreferenced from KConfig side from the linux source code so there's
> only a small bit of it left in KBuild. Mayee remove it as well?
>
> ./fs/xfs/Makefile:95
> +++>
>
> xfs-$(CONFIG_XFS_TRACE)         += xfs_btree_trace.o
>
> <+++

  if the reference is being removed from the Makefile, wouldn't it
also make sense to delete the corresponding source file as well?

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

<Prev in Thread] Current Thread [Next in Thread>