Re: [PATCH 3/8] xfstests: Don't use tempnam in growfiles.c

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 3/8] xfstests: Don't use tempnam in growfiles.c
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 20 Jan 2010 03:28:09 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1263958688-435-4-git-send-email-david@xxxxxxxxxxxxx>
References:	<1263958688-435-1-git-send-email-david@xxxxxxxxxxxxx> <1263958688-435-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Wed, Jan 20, 2010 at 02:38:03PM +1100, Dave Chinner wrote:
> tempnam() generates a compiler warning as a dangerous function.
> This code doesn't care about security issues with tempnam, so
> remove it and just manually build the filenames without the
> randomness of tempnam.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>


Btw, I wonder if we should sync back changes to the ltp/* files to LTP..

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/8] xfstests: fix compile warnings, Dave Chinner [PATCH 4/8] xfstests: fix printf format warnings in aio-stress.c, Dave Chinner Re: [PATCH 4/8] xfstests: fix printf format warnings in aio-stress.c, Christoph Hellwig [PATCH 7/8] xfstests: fix printf warnings in locktest.c, Dave Chinner Re: [PATCH 7/8] xfstests: fix printf warnings in locktest.c, Christoph Hellwig [PATCH 3/8] xfstests: Don't use tempnam in growfiles.c, Dave Chinner Re: [PATCH 3/8] xfstests: Don't use tempnam in growfiles.c, Christoph Hellwig <= [PATCH 2/8] xfstests: fix bulkstat related compile warnings., Dave Chinner Re: [PATCH 2/8] xfstests: fix bulkstat related compile warnings., Christoph Hellwig [PATCH 6/8] xfstests: fix printf format warnings in looptest.c, Dave Chinner Re: [PATCH 6/8] xfstests: fix printf format warnings in looptest.c, Christoph Hellwig [PATCH 5/8] xfstests: fix compile warnings in iopat.c, Dave Chinner Re: [PATCH 5/8] xfstests: fix compile warnings in iopat.c, Christoph Hellwig [PATCH 8/8] xfstests: don't redefine _GNU_SOURCE in aio tests, Dave Chinner Re: [PATCH 8/8] xfstests: don't redefine _GNU_SOURCE in aio tests, Christoph Hellwig [PATCH 1/8] xfstests: fix compile warning in doio.c, Dave Chinner Re: [PATCH 1/8] xfstests: fix compile warning in doio.c, Christoph Hellwig

Previous by Date:	Re: [PATCH 2/8] xfstests: fix bulkstat related compile warnings., Christoph Hellwig
Next by Date:	Re: [PATCH 4/8] xfstests: fix printf format warnings in aio-stress.c, Christoph Hellwig
Previous by Thread:	[PATCH 3/8] xfstests: Don't use tempnam in growfiles.c, Dave Chinner
Next by Thread:	[PATCH 2/8] xfstests: fix bulkstat related compile warnings., Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]