xfs
[Top] [All Lists]

Re: [PATCH 3/8] xfstests: Don't use tempnam in growfiles.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/8] xfstests: Don't use tempnam in growfiles.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 20 Jan 2010 03:28:09 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263958688-435-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1263958688-435-1-git-send-email-david@xxxxxxxxxxxxx> <1263958688-435-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Jan 20, 2010 at 02:38:03PM +1100, Dave Chinner wrote:
> tempnam() generates a compiler warning as a dangerous function.
> This code doesn't care about security issues with tempnam, so
> remove it and just manually build the filenames without the
> randomness of tempnam.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>


Btw, I wonder if we should sync back changes to the ltp/* files to LTP..

<Prev in Thread] Current Thread [Next in Thread>