xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Convert all tests to use /bin/bash

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Convert all tests to use /bin/bash
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 19 Jan 2010 17:37:25 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263891633-30868-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1263891633-30868-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Dave Chinner wrote:
> While most tests use /bin/sh, they are dependent on /bin/sh being a
> bash shell.  Convert all the tests to execute via /bin/bash as it is
> much, much simpler than trying to debug and remove all the bashisms
> throughout the test code.
> 
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

well, spoke a little too soon.

OK as far as it goes, but not quite far enough :)

the "new" file still contains sh and I guess it could be used
as a template so maybe fix that up.

and do you care about things like:

        | tee -a $here/$seq.full | sh


in 001?

-Eric

<Prev in Thread] Current Thread [Next in Thread>