Re: [PATCH] xfstests: Convert all tests to use /bin/bash

xfs

Re: [PATCH] xfstests: Convert all tests to use /bin/bash

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] xfstests: Convert all tests to use /bin/bash
From:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Date:	Tue, 19 Jan 2010 17:25:44 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1263891633-30868-1-git-send-email-david@xxxxxxxxxxxxx>
References:	<1263891633-30868-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Thunderbird 2.0.0.23 (Macintosh/20090812)

Dave Chinner wrote:
> While most tests use /bin/sh, they are dependent on /bin/sh being a
> bash shell.  Convert all the tests to execute via /bin/bash as it is
> much, much simpler than trying to debug and remove all the bashisms
> throughout the test code.
> 
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Seems fine,

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfstests: Convert all tests to use /bin/bash, Dave Chinner Re: [PATCH] xfstests: Convert all tests to use /bin/bash, Eric Sandeen <= Re: [PATCH] xfstests: Convert all tests to use /bin/bash, Eric Sandeen

Previous by Date:	Re: [1/3] xfs: remove duplicate buffer flags, Alex Elder
Next by Date:	Re: [PATCH] xfstests: Convert all tests to use /bin/bash, Eric Sandeen
Previous by Thread:	[PATCH] xfstests: Convert all tests to use /bin/bash, Dave Chinner
Next by Thread:	Re: [PATCH] xfstests: Convert all tests to use /bin/bash, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]