[Top] [All Lists]

Re: [PATCH 1/3] [PATCH] xfs: remove duplicate buffer flags

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] [PATCH] xfs: remove duplicate buffer flags
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 20 Jan 2010 10:12:30 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100119095654.708720933@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100119095643.378866749@xxxxxxxxxxxxxxxxxxxxxx> <20100119095654.708720933@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Jan 19, 2010 at 04:56:44AM -0500, Christoph Hellwig wrote:
> Currently we define aliases for the buffer flags in various namespaces,
> which only adds confusion.  Remove all but the XBF_ flags to clean this
> up a bit.
> Note that we still abuse XFS_B_ASYNC/XBF_ASYNC for some non-buffer uses,
> but I'll clean that up later.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. This has been on my "things for a rainy day" list for
quite some time.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>
Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>