xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfsprogs: Do not remove configure information on clean

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfsprogs: Do not remove configure information on clean
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 19 Jan 2010 22:09:26 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100119091531.GA29269@xxxxxxxxxxxxx>
References: <1263861186-13589-1-git-send-email-david@xxxxxxxxxxxxx> <1263861186-13589-2-git-send-email-david@xxxxxxxxxxxxx> <20100119091531.GA29269@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Jan 19, 2010 at 04:15:31AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 19, 2010 at 11:33:05AM +1100, Dave Chinner wrote:
> > ??ormal packaging practice is to remove the configure scripts
> > on a 'make distclean' so that a 'make clean' doesn't result in
> > having to rerun the configure scripts. Change the clean targets
> > in the top level makefile to only clear configure files on
> > a distclean.
> > 
> > Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
> > ---
> >  Makefile |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 2d394e4..a7615ca 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -15,7 +15,7 @@ SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
> >  CONFIGURE = aclocal.m4 configure config.guess config.sub install-sh 
> > ltmain.sh
> >  LSRCFILES = configure.in release.sh README VERSION $(CONFIGURE)
> >  
> > -LDIRT = config.log .dep config.status config.cache confdefs.h conftest* \
> > +DISTDIRT = config.log .dep config.status config.cache confdefs.h conftest* 
> > \
> >     built .census install.* install-dev.* *.gz autom4te.cache/* libtool \
> >     include/builddefs include/platform_defs.h
> 
> But this isn't all configure stuff, is it?  install.* install-dev.* *.gz
> is from the install process, and .dep is part of make dep.

Hmm - I never do make installs - I always build packages because I
build on a different machine to the ones I test one. I'll check it
out, but I've never seen install* files generated in the top level.

For the *.gz files, the tarballs are generated by "make dist",
so shouldn't they be removed by "make distclean"?

As to depenencies, we have no "make dep" target, there doesn't
appear to be any makefile gunk to generate them, and the
dependencies are completely busted. That's on my list to fix.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>