xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: convert attr to use unsigned names

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/8] xfs: convert attr to use unsigned names
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 19 Jan 2010 04:32:47 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263861026-13448-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1263861026-13448-1-git-send-email-david@xxxxxxxxxxxxx> <1263861026-13448-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Jan 19, 2010 at 11:30:24AM +1100, Dave Chinner wrote:
> To be consistent with the directory code, the attr code should use
> unsigned names. Convert the names from the vfs at the highest level
> to unsigned, and ??nsure they are consistenly used as unsigned down
> to disk.
> 
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
> ---
>  fs/xfs/linux-2.6/xfs_acl.c     |   11 ++++++-----
>  fs/xfs/linux-2.6/xfs_ioctl.c   |   18 +++++++++---------
>  fs/xfs/linux-2.6/xfs_ioctl.h   |   12 ++++++------
>  fs/xfs/linux-2.6/xfs_ioctl32.c |    4 ++--
>  fs/xfs/linux-2.6/xfs_iops.c    |    4 ++--
>  fs/xfs/linux-2.6/xfs_xattr.c   |   27 +++++++++++++++++++--------
>  fs/xfs/xfs_acl.h               |    4 ++--
>  fs/xfs/xfs_attr.c              |   38 +++++++++++++++++++++++---------------
>  fs/xfs/xfs_attr.h              |    2 +-
>  fs/xfs/xfs_attr_leaf.c         |   28 ++++++++++++++--------------
>  fs/xfs/xfs_attr_sf.h           |    2 +-
>  fs/xfs/xfs_vnodeops.h          |   10 +++++-----
>  12 files changed, 90 insertions(+), 70 deletions(-)
> 
> diff --git a/fs/xfs/linux-2.6/xfs_acl.c b/fs/xfs/linux-2.6/xfs_acl.c

It's a bit unfortunate that the highlevel xattr code gets char froms the
VFS, but better convert them at the highest level and keep the lower
ones clean, so:


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>