xfs
[Top] [All Lists]

Re: [PATCH 8/8] xfs: make compile warn about char sign mismatches again

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 8/8] xfs: make compile warn about char sign mismatches again
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 19 Jan 2010 04:29:39 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263861026-13448-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1263861026-13448-1-git-send-email-david@xxxxxxxxxxxxx> <1263861026-13448-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Jan 19, 2010 at 11:30:26AM +1100, Dave Chinner wrote:
> The -fno-unsigned-char directive has no effect anymore as the
> XFs build is clean. However, the kernel build hides pointer sign
> differences so turn that back on so that we can clean up all the
> mismatches prior to a userspace code resync.

Not so happy about turning the warning on so we have local compiler
warning differences from the rest of the kernel again, but it's not
that bad, so


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> index 6f26875..9f7c001 100644
> --- a/fs/xfs/xfs_vnodeops.c
> +++ b/fs/xfs/xfs_vnodeops.c
> @@ -2199,7 +2199,8 @@ xfs_symlink(
>       if (DM_EVENT_ENABLED(dp, DM_EVENT_SYMLINK)) {
>               error = XFS_SEND_NAMESP(mp, DM_EVENT_SYMLINK, dp,
>                                       DM_RIGHT_NULL, NULL, DM_RIGHT_NULL,
> -                                     link_name->name, target_path, 0, 0, 0);
> +                                     link_name->name,
> +                                     (unsigned char *)target_path, 0, 0, 0);
>               if (error)
>                       return error;
>       }
> @@ -2395,7 +2396,8 @@ std_return:
>                                       dp, DM_RIGHT_NULL,
>                                       error ? NULL : ip,
>                                       DM_RIGHT_NULL, link_name->name,
> -                                     target_path, 0, error, 0);
> +                                     (unsigned char *)target_path,
> +                                     0, error, 0);

These changes are nowhere mentioned in the changelog.  And they probably
belong into the patch changing the dmapi events to take unsigned chars.

<Prev in Thread] Current Thread [Next in Thread>