| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/8] xfs: xfs_buf_iomove() doesn't care about signedness |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 19 Jan 2010 04:27:02 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1263861026-13448-6-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1263861026-13448-1-git-send-email-david@xxxxxxxxxxxxx> <1263861026-13448-6-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Tue, Jan 19, 2010 at 11:30:23AM +1100, Dave Chinner wrote: > xfs_buf_iomove() uses xfs_caddr_t as it's parameter types, but it doesn't > care about the signedness of the variables as it is just copying the > data. Change the prototype to use void * so that we don't get sign > warnings at call sites. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 4/8] xfs: make xfs_dir_cilookup_result use unsigned char, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 7/8] xfs: clean up sign warnings in dir2 code, Christoph Hellwig |
| Previous by Thread: | [PATCH 5/8] xfs: xfs_buf_iomove() doesn't care about signedness, Dave Chinner |
| Next by Thread: | [PATCH 1/8] xfs: directory names are unsigned, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |