xfs
[Top] [All Lists]

Re: [PATCH 4/8] xfs: make xfs_dir_cilookup_result use unsigned char

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/8] xfs: make xfs_dir_cilookup_result use unsigned char
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 19 Jan 2010 04:26:48 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263861026-13448-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1263861026-13448-1-git-send-email-david@xxxxxxxxxxxxx> <1263861026-13448-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Jan 19, 2010 at 11:30:22AM +1100, Dave Chinner wrote:
> For consistency with the result of the code.
> 
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
> ---
>  fs/xfs/xfs_dir2.c |    2 +-
>  fs/xfs/xfs_dir2.h |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_dir2.c b/fs/xfs/xfs_dir2.c
> index c21c527..3a8c6ba 100644
> --- a/fs/xfs/xfs_dir2.c
> +++ b/fs/xfs/xfs_dir2.c
> @@ -247,7 +247,7 @@ xfs_dir_createname(
>  int
>  xfs_dir_cilookup_result(
>       struct xfs_da_args *args,
> -     const char      *name,
> +     const unsigned char *name,
>       int             len)
>  {

Given that the value we copy things into is unsigned anyway this looks
correct,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>