xfs
[Top] [All Lists]

Re: [PATCH 2/8] xfs: convert DM ops to use unsigned char names

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/8] xfs: convert DM ops to use unsigned char names
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 19 Jan 2010 04:25:07 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263861026-13448-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1263861026-13448-1-git-send-email-david@xxxxxxxxxxxxx> <1263861026-13448-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Jan 19, 2010 at 11:30:20AM +1100, Dave Chinner wrote:
> dmops uses a signed char for it's namespace event. To be consistent
> with the rest of the code, convert them to unsigned char for the
> namespace string.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

possibly we should just get rid of the dm hooks now that they've been
dead for years..

<Prev in Thread] Current Thread [Next in Thread>