[Top] [All Lists]

Re: [PATCH 3/3] xfsqa: xfs_check can see stale cached blocks

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfsqa: xfs_check can see stale cached blocks
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 19 Jan 2010 04:19:07 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263891792-30952-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1263891792-30952-1-git-send-email-david@xxxxxxxxxxxxx> <1263891792-30952-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Jan 19, 2010 at 08:03:12PM +1100, Dave Chinner wrote:
> Test 017 is consistently failing now because the xfs_check uses
> buffered IO to read the block device and 017 runs xfs_check ona
> remount,ro filesystem. Hence the block device cache is never
> invalidated (the unmount path does this) and so xfs_check can see
> stale blocks from previous invocations instead of what is really on
> disk at the time it is run.
> Manually trash the page cache before running xfs_check to ensure
> that the blockdev cache is clean and we don't get false errors
> from stale blocks.

I don't think this is correct.  We need to provide this synchronization
from kernel land.  IIRC Al even has a patch towards this in his tree,
can't point you to it to try it because his tree on kernel.org seems
messed up right now.

<Prev in Thread] Current Thread [Next in Thread>