| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] mkfs: don't warn about topology when mkfsing a file |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 19 Jan 2010 12:04:43 +1100 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4B54B4D1.7020500@xxxxxxxxxxx> |
| References: | <4B54B4D1.7020500@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Mon, Jan 18, 2010 at 01:21:53PM -0600, Eric Sandeen wrote: > Some tests were failing for me like: > > QA output created by 206 > === truncate file === > === mkfs.xfs === > +warning: unable to probe device toplology for device /mnt/test/fsfile.21615 > ... > > I thought about filtering the tests, but ... > > It seems that we shouldn't even be trying to get topology for a > plain file, should we? And then we won't warn about failure. > > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> Sound pretty sane to me. Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/2] xfs: suppress spurious uninitialised var warning in xfs_bmapi(), Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfsteststs: get fsstress DIO working on non-xfs filesystems, Dave Chinner |
| Previous by Thread: | [PATCH] mkfs: don't warn about topology when mkfsing a file, Eric Sandeen |
| Next by Thread: | Re: [PATCH] mkfs: don't warn about topology when mkfsing a file, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |