xfs
[Top] [All Lists]

[PATCH 8/8] xfs: make compile warn about char sign mismatches again

To: xfs@xxxxxxxxxxx
Subject: [PATCH 8/8] xfs: make compile warn about char sign mismatches again
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 19 Jan 2010 11:30:26 +1100
In-reply-to: <1263861026-13448-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1263861026-13448-1-git-send-email-david@xxxxxxxxxxxxx>
The -fno-unsigned-char directive has no effect anymore as the
XFs build is clean. However, the kernel build hides pointer sign
differences so turn that back on so that we can clean up all the
mismatches prior to a userspace code resync.

Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
---
 fs/xfs/Makefile       |    2 +-
 fs/xfs/xfs_vnodeops.c |    6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
index 56641fe..1926701 100644
--- a/fs/xfs/Makefile
+++ b/fs/xfs/Makefile
@@ -16,7 +16,7 @@
 # Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 #
 
-EXTRA_CFLAGS +=         -I$(src) -I$(src)/linux-2.6 -funsigned-char
+EXTRA_CFLAGS +=         -I$(src) -I$(src)/linux-2.6 -Wpointer-sign
 
 XFS_LINUX := linux-2.6
 
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c
index 6f26875..9f7c001 100644
--- a/fs/xfs/xfs_vnodeops.c
+++ b/fs/xfs/xfs_vnodeops.c
@@ -2199,7 +2199,8 @@ xfs_symlink(
        if (DM_EVENT_ENABLED(dp, DM_EVENT_SYMLINK)) {
                error = XFS_SEND_NAMESP(mp, DM_EVENT_SYMLINK, dp,
                                        DM_RIGHT_NULL, NULL, DM_RIGHT_NULL,
-                                       link_name->name, target_path, 0, 0, 0);
+                                       link_name->name,
+                                       (unsigned char *)target_path, 0, 0, 0);
                if (error)
                        return error;
        }
@@ -2395,7 +2396,8 @@ std_return:
                                        dp, DM_RIGHT_NULL,
                                        error ? NULL : ip,
                                        DM_RIGHT_NULL, link_name->name,
-                                       target_path, 0, error, 0);
+                                       (unsigned char *)target_path,
+                                       0, error, 0);
        }
 
        if (!error)
-- 
1.6.5

<Prev in Thread] Current Thread [Next in Thread>