xfs
[Top] [All Lists]

Re: [PATCH 5/9] xfsprogs: fix some trivial warnings in xfs_db

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/9] xfsprogs: fix some trivial warnings in xfs_db
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 17 Jan 2010 07:12:43 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263463752-5052-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1263463752-5052-1-git-send-email-david@xxxxxxxxxxxxx> <1263463752-5052-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Jan 14, 2010 at 09:09:08PM +1100, Dave Chinner wrote:
> Three warnings, none harmful - one dir2 name sign warning and
> two cases where gcc can't work out if a variable is initialised
> correctly in a child function or not.

Might be worth to throw all the dabtree sign things in with the mign
signed issue patch?

Anyway, the changes look good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>