[Top] [All Lists]

Re: [PATCH] xfsdump: Clean up build output

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsdump: Clean up build output
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 17 Jan 2010 07:00:12 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263429589-12896-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1263429589-12896-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Jan 14, 2010 at 11:39:49AM +1100, Dave Chinner wrote:
> We don't need to see every compiler command line for every file that
> is compiled. This makes it hard to see warnings and errors during
> compile. For progress notification, we really only need to see the
> directory/file being operated on.
> Turn down the verbosity of output by suppressing various make output
> and provide better overall visibility of which directory is being
> operated on, what the operation is and what is being done to the
> files by the build/clean process. Also fix the top level clean rule
> so that we don't run configure scripts after a make clean, only
> after a make distclean.
> The old style verbose builds can still be run via "make V=1 ..."

Looks good except that the make clean changes really should be separate
as in xfsprogs.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

For the both bits, although they should be separate.

<Prev in Thread] Current Thread [Next in Thread>