xfs
[Top] [All Lists]

Re: [PATCH] xfstests 073: unmount source image in cleanup

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests 073: unmount source image in cleanup
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 17 Jan 2010 06:41:31 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4B510B41.3070904@xxxxxxxxxx>
References: <4B510B41.3070904@xxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, Jan 15, 2010 at 06:41:37PM -0600, Eric Sandeen wrote:
> Test 073 is currently failing w/ xfs_repair problems, and when
> it does, the whole series stops because the test dir still has
> a loopback mounted filesystem on it, and it can't unmount.
> 
> Fix that.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> ---
> 
> diff --git a/073 b/073
> index 0ef9287..756c1c8 100755
> --- a/073
> +++ b/073
> @@ -44,6 +44,7 @@ _cleanup()
>       umount $SCRATCH_MNT 2>/dev/null
>       umount -d $imgs.loop 2>/dev/null
>       [ -d $imgs.loop ] && rmdir $imgs.loop
> +     umount -d $imgs.source_dir 2>/dev/null
>       [ -d $imgs.source_dir ] && rm -rf $imgs.source_dir
>       rm -f $imgs.* $tmp.* /var/tmp/xfs_copy.log.*

Yes, we should always unmount everything in the cleanup handler.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>