xfs
[Top] [All Lists]

Re: [PATCH] remove bashisms from xfstests

To: Christian Kujau <lists@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] remove bashisms from xfstests
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 15 Jan 2010 18:19:06 +1100
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <alpine.DEB.2.01.1001032348240.3483@xxxxxxxxxxxxxxxxxx>
References: <alpine.DEB.2.01.1001030125040.3483@xxxxxxxxxxxxxxxxxx> <87vdfjceke.fsf@xxxxxxxxxxxxxxxxx> <alpine.DEB.2.01.1001032307210.3483@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.01.1001032348240.3483@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Jan 03, 2010 at 11:56:45PM -0800, Christian Kujau wrote:
> On Sun, 3 Jan 2010 at 23:27, Christian Kujau wrote:
> > OK, here's one with only changing /bin/sh to /bin/bash, for all scripts 
> > carrying bashisms according to checkbashisms(1). With this patch applied, 
> > I can now run xfstests w/o changing my /bin/sh to something else.
> 
> Well, almost - I'm still getting errors, because some of the scripts are 
> not executed but sourced. Although the ./check script is /bin/bash now, 
> the sourced scripts seem to get executed via /bin/sh, at least that's what 
> I've experienced. Here's an additional patch, changing only the common.* 
> scripts, for they are being sourced. Right now xfstests is running test 
> 013 and no errors so far.

Even with this patch I notice that 005 fails, 007 hangs, mkfs fails in
015 and 016 because of some kind of parameter passing problem
fail, and and all of these work by specifying /bin/bash rather than
/bin/sh.

I haven't got any further than this - it's painfully slow having to
test them one at a time because I'm getting lots of failures since
upgrading my test box from xfsprogs 3.0.4 to 3.1.0 this morning as
well as to the latest debian unstable.

Right now, considering the apparent widespread dependency on bash in
these test scripts, I'm proposing that we just change every single
test to run /bin/bash and hence avoid all these problems without
needing extra changes to the tests.

Comments?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>