xfs
[Top] [All Lists]

RE: [PATCH 1/3] xfs: kill XFS_QMOPT_ASYNC

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: RE: [PATCH 1/3] xfs: kill XFS_QMOPT_ASYNC
From: "Alex Elder" <aelder@xxxxxxx>
Date: Thu, 14 Jan 2010 12:59:34 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20100113220602.632551077@xxxxxxxxxxxxxxxxxxxxxx>
Thread-index: AcqUoNRX9abwr9LWThCIYXFgqdCQ9wAqtItg
Thread-topic: [PATCH 1/3] xfs: kill XFS_QMOPT_ASYNC
Christoph Hellwig wrote:
> The option is unused and one of the few remaining users of xfs_bawrite,
> so let's get rid of it.

Looks good.

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Alex Elder <aelder@xxxxxxx>


> Index: linux-2.6/fs/xfs/quota/xfs_dquot.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/quota/xfs_dquot.c   2010-01-08 15:10:07.694006652 
> +0100
> +++ linux-2.6/fs/xfs/quota/xfs_dquot.c        2010-01-08 15:10:26.227006460 
> +0100
> @@ -1253,8 +1253,6 @@ xfs_qm_dqflush(
> 
>       if (flags & XFS_QMOPT_DELWRI) {
>               xfs_bdwrite(mp, bp);
> -     } else if (flags & XFS_QMOPT_ASYNC) {
> -             error = xfs_bawrite(mp, bp);
>       } else {
>               error = xfs_bwrite(mp, bp);
>       }
> Index: linux-2.6/fs/xfs/xfs_quota.h
> ===================================================================
> --- linux-2.6.orig/fs/xfs/xfs_quota.h 2010-01-08 15:10:07.729006360 +0100
> +++ linux-2.6/fs/xfs/xfs_quota.h      2010-01-08 15:10:12.062005658 +0100
> @@ -226,7 +226,6 @@ typedef struct xfs_qoff_logformat {
>   * flags for dqflush and dqflush_all.
>   */
>  #define XFS_QMOPT_SYNC               0x1000000
> -#define XFS_QMOPT_ASYNC              0x2000000
>  #define XFS_QMOPT_DELWRI     0x4000000
> 
>  /*
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>