xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfs: implement quota warnings via netlink

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfs: implement quota warnings via netlink
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 14 Jan 2010 01:42:28 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100114011948.GV17483@xxxxxxxxxxxxxxxx>
References: <20100113220547.846700560@xxxxxxxxxxxxxxxxxxxxxx> <20100113220603.251930871@xxxxxxxxxxxxxxxxxxxxxx> <20100114011948.GV17483@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Jan 14, 2010 at 12:19:48PM +1100, Dave Chinner wrote:
> > Tested by running the quota_nld daemon while running the xfstest quota
> > tests and observing the warnings.  I'll see how I can get a more formal
> > testcase for it written.
> 
> Sounds like it needs something similar to the dmapi event listeners
> we use for testing that the dmapi events are generated correctly....

That's what quota_nld does, just need to tie it up properly.

> This appears to send "over block quota" warnings even when
> the error is caused by the number of inodes going over limit.
> For inode count warnings we should be sending QUOTA_NL_IHARDWARN or
> QUOTA_NL_ISOFTWARN. That could be easily done if the "hard"
> parameter is changed to the type of warning which is set up
> in the calling function.
> 
> We could probably even return the grace limit expired versions
> as well when over the soft limits with a slight change to the
> soft limit warning logic as well...

Indeed, I did copy this from gfs2 which only does the block quotas
and no differciated soft warnings.  I'll respin it.

<Prev in Thread] Current Thread [Next in Thread>