xfs
[Top] [All Lists]

Re: [PATCH] xfs: xfs_swap_extents needs to handle dynamic fork offsets

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfs: xfs_swap_extents needs to handle dynamic fork offsets
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 14 Jan 2010 01:35:10 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A6965@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20100112130922.GA30985@xxxxxxxxxxxxx> <1AB9A794DBDDF54A8A81BE2296F7BDFE012A6965@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Jan 13, 2010 at 04:32:12PM -0600, Alex Elder wrote:
> Christoph Hellwig wrote:
> >> +  TP_printk("dev %d:%d %s inode 0x%llx, %s format, num_extents %d, "
> >> +            "Max in-fork extents %d, broot size %d, fork offset %d",
> > 
> > It would be nice to keep the
> > 
> >     "dev %d:%d ino 0x%llx"
> > 
> > prefix as a convention so that all trace records are similar at their
> > beginning.
> 
> Perhaps:
>     + TP_printk("dev %d:%d inode 0x%llx (%s), %s format, num_extents %d, " 
>                                           ^
>                                           +--- symbolic entry->which

Sounds fine, except s/inode/ino/ above to stay consistant.

<Prev in Thread] Current Thread [Next in Thread>