xfs
[Top] [All Lists]

RE: [PATCH] xfsprogs: Make the compile output cleaner V2

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>, "Dave Chinner" <david@xxxxxxxxxxxxx>
Subject: RE: [PATCH] xfsprogs: Make the compile output cleaner V2
From: "Alex Elder" <aelder@xxxxxxx>
Date: Wed, 13 Jan 2010 16:43:33 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20100113220814.GA17310@xxxxxxxxxxxxx>
Thread-index: AcqUoNTOHCOSBAGzSB+c06No0xrprAAAKOfg
Thread-topic: [PATCH] xfsprogs: Make the compile output cleaner V2
Christoph Hellwig wrote:
> On Wed, Jan 13, 2010 at 09:03:27PM +1100, Dave Chinner wrote:
>> -LDIRT = config.log .dep config.status config.cache confdefs.h conftest* \
>> +DISTDIRT = config.log .dep config.status config.cache confdefs.h conftest* \
>>      built .census install.* install-dev.* *.gz autom4te.cache/* libtool \
>>      include/builddefs include/platform_defs.h
> 
>>  distclean: clean
>> -    rm -f $(LDIRT)
>> +    $(Q)rm -f $(DISTDIRT)
> 
> What does this have to do with the rest?
> 
> Otherwise looks good,

I didn't get the original in my e-mail or I would have
responded to it directly.  I like this change a lot.

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> Any chance you could also port it to xfsdump?

And dmapi and xfstests, for that matter...

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>