xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: fix build with latest glibc headers

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: fix build with latest glibc headers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2010 16:42:06 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4B4E365E.8000306@xxxxxxxxxx>
References: <4B4E365E.8000306@xxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Jan 13, 2010 at 03:08:46PM -0600, Eric Sandeen wrote:
> glibc in rawhide has some changes...
> 
> * Tue Jan 12 2010 Andreas Schwab <schwab@xxxxxxxxxx> - 2.11.90-8
> - Update from master.
>   - More POSIX conformance fixes.
> 
> * Mon Jan 11 2010 Andreas Schwab <schwab@xxxxxxxxxx> - 2.11.90-6
> - Update from master.
>   - POSIX conformance fixes (BZ#11125).

Great, eh? :)

> @@ -102,7 +102,7 @@ GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
>  #       -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-decl
>  
>  ifeq ($(PKG_PLATFORM),linux)
> -PCFLAGS = -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 $(GCCFLAGS)
> +PCFLAGS = -D_GNU_SOURCE -D_XOPEN_SOURCE=500 -D_FILE_OFFSET_BITS=64 
> $(GCCFLAGS)

We might aswell got to -D_XOPEN_SOURCE=700 which is the newest revision and
should give us just about everything we might need.


But generally this looks okay to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>