xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: Make the compile output cleaner

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: Make the compile output cleaner
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 12 Jan 2010 22:29:24 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4B4D433C.7080501@xxxxxxxxxxx>
References: <1263350021-5733-1-git-send-email-david@xxxxxxxxxxxxx> <4B4D433C.7080501@xxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Eric Sandeen wrote:

> Dave Chinner wrote:
>   
>> We don't need to see every compiler command line for every file that
>> is compiled. This makes it hard to see warnings and errors during
>> compile. For progress notification, we really only need to see the
>> diretory/file being operated on.
>>
>> Turn down the verbosity of output by suppressing various make output
>> and provide better overall visibility of which directory is being
>> operated on, what the operation is and what is being done to the
>> files by the build/clean process.
>>
>> Sample output from a build:
>>
>> ....
>> Building libxlog
>>     [CC] xfs_log_recover.c
>>     [CC] util.c
>>     [LD] libxlog.la
>>   
>>     
>
> ...
>
> swanky!
>
> What would you think of this on top of it, ripped straight from
> kbuild - that way "make V=1" works the same way as kbuild, but
> the default is still to be quiet.
>
> Also, just to show my kbuild bias, maybe consider outputting the target
> on the quiet line, instead of the source?  :)  But no biggie.
>
> -Eric
>
>   
ok now I'm being a make junkie, but a couple more things are "noisy"

Building include
    [LN] xfs
    [LN] disk
...
Building doc
   [ZIP] CHANGES.gz
Building po
[GETTXT] xfsprogs.pot

-Eric

diff --git a/include/Makefile b/include/Makefile
index d89480e..42e7233 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -43,7 +43,8 @@ LDIRT = xfs disk
 default install: xfs disk
 
 xfs disk:
-       $(LN_S) . $@
+       @echo "    [LN]" $@
+       $(Q)$(LN_S) . $@
 
 include $(BUILDRULES)
 diff --git a/doc/Makefile b/doc/Makefile
index 8f65b66..0a6de15 100644
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -13,7 +13,8 @@ default: CHANGES.gz
 include $(BUILDRULES)
 
 CHANGES.gz:
-       $(ZIP) --best -c < CHANGES > $@
+       @echo "   [ZIP] $@"
+       $(Q)$(ZIP) --best -c < CHANGES > $@
 
 install: default

        $(INSTALL) -m 755 -d $(PKG_DOC_DIR)

diff --git a/include/buildrules b/include/buildrules
index 72edc69..ba004e6 100644
--- a/include/buildrules
+++ b/include/buildrules
@@ -61,7 +61,8 @@ endif
 
 ifdef POTHEAD
 $(POTHEAD): $(XGETTEXTFILES)
-       $(XGETTEXT) --language=C --keyword=_ --keyword=N_ -o $@ $(XGETTEXTFILES)
+       @echo "[GETTXT] $@"
+       $(Q)$(XGETTEXT) --language=C --keyword=_ --keyword=N_ -o $@ 
$(XGETTEXTFILES)
 
 # Update translations
 update-po: $(POTHEAD) $(wildcard $(TOPDIR)/po/*.po)

<Prev in Thread] Current Thread [Next in Thread>