On Sun, Jan 10, 2010 at 04:26:19PM -0500, Christoph Hellwig wrote:
> By mounting the filesystem with quotas enabled in 087 we exercise the
> replay of the quota log items in this tests, which we otherwise don't
> test in xfstests. OSS bugzilla #855 is an example of something caught
> by this.
> Does this look okay, or should I add a duplicate of
> 087 with quotas enabled instead?
I think having 087 cover quotas as well is fine. Adding a separate
test just for quotas doesn't provide any extra coverage compared to
> @@ -98,7 +100,7 @@ do
> # mount the FS
> _echofull "mount"
> - if ! _scratch_mount >>$seq.full 2>&1; then
> + if ! _scratch_mount -o uquota >>$seq.full 2>&1; then
My only question is whether this will work if uquota is set up as a
global option. I haven't looked into it yet, but there appears to be
several different ways that uquota is specified in other tests:
116:mount -o uquota $SCRATCH_DEV $SCRATCH_MNT
220:_scratch_mount -o uquota
Some consistency would be nice, but I don't think it's a problem
for this patch right now.
Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>