xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfsqa: make unmounting loop devices in 073 work again

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/4] xfsqa: make unmounting loop devices in 073 work again
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Jan 2010 22:51:17 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100112100031.GA8749@xxxxxxxxxxxxx>
References: <1263271269-18997-1-git-send-email-david@xxxxxxxxxxxxx> <1263271269-18997-3-git-send-email-david@xxxxxxxxxxxxx> <20100112100031.GA8749@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Jan 12, 2010 at 05:00:31AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 12, 2010 at 03:41:07PM +1100, Dave Chinner wrote:
> > Loop devices are now created and destroyed on demand, and
> > the existing hacks to do this no longer work. Remove them.
> 
> Just noticed that I had not been running this test at all for a long
> time as it doesn't work with external logs.
> 
> Seems like the current code indeed fails reliably for me and this
> patch fixes it.
> 
> The only problem is that the loop device autodestruct features is only
> available since Linux 2.6.25 and also needs a recent util-linux.  Is
> this old enough to simply go with the auto destruct version, or do
> we need to support either one?
> 
> What about the patch below?  This adds the -d argument to the umount
> calls for the loop images, which destroys the loop images in older
> kernels and is a no-op for modern kernels that have the loop
> auto-destruct feature:

Yes, that looks like a better way to solve the problem.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>