| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/4] xfsqa: add simple xfs_fsr test |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 12 Jan 2010 04:50:17 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1263271269-18997-5-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1263271269-18997-1-git-send-email-david@xxxxxxxxxxxxx> <1263271269-18997-5-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Tue, Jan 12, 2010 at 03:41:09PM +1100, Dave Chinner wrote: > We have very little fsr test coverage in the test suite right now. > 042 is the only test that runs it, and it only defragments a single > file. > > Improve the coverage by simply running xfs_fsr of the test > filesystem. This gives xfs_fsr a wide variety of inodes to try to > defragment. A simple test like this would have tripped over the > attr2 fork offset problems in the swap extents ioctl long ago > thanks to the varied nature of inodes the test suite leaves around > in this filesystem. Looks good, and having it after 200+ testcases also means it should have at least a bit of work to do. Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/4] xfsqa: filter log size in 206, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/4] xfsqa: make unmounting loop devices in 073 work again, Christoph Hellwig |
| Previous by Thread: | [PATCH 4/4] xfsqa: add simple xfs_fsr test, Dave Chinner |
| Next by Thread: | [PATCH 3/4] xfsqa: filter log size in 206, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |