[Top] [All Lists]

Re: [PATCH 3/4] xfsqa: filter log size in 206

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/4] xfsqa: filter log size in 206
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 12 Jan 2010 04:47:45 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263271269-18997-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1263271269-18997-1-git-send-email-david@xxxxxxxxxxxxx> <1263271269-18997-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Jan 12, 2010 at 03:41:08PM +1100, Dave Chinner wrote:
> With the log size now going past 128MB, test 206 creates a filesystem
> with a much larger log than 128MB. The golden output expects at
> 128MB log size, so the test breaks. Filter the log size out of the
> mkfs output and golden output so that the test works on both older and
> newer mkfs binaries.

I guess you'll need a large enough test filesystem to hit this so I
don't see it, but it looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>