xfs
[Top] [All Lists]

Re: [PATCH 3/3] XFS: Don't wake xfsbufd when idle

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] XFS: Don't wake xfsbufd when idle
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 11 Jan 2010 16:51:48 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263210599-25067-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1263210599-25067-1-git-send-email-david@xxxxxxxxxxxxx> <1263210599-25067-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Jan 11, 2010 at 10:49:59PM +1100, Dave Chinner wrote:
> The xfsbufd wakes every xfsbufd_centisecs (once per second by
> default) for each filesystem even when the filesystem is idle.
> If the xfsbufd has nothing to do, put it into a long term sleep
> and only wake it up when there is work pending (i.e. dirty
> buffers to flush soon). This will make laptop power misers happy.
> 
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>