xfs
[Top] [All Lists]

Re: [PATCH 2/3] XFS: Don't wake the aild once per second

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] XFS: Don't wake the aild once per second
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 11 Jan 2010 16:51:12 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263210599-25067-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1263210599-25067-1-git-send-email-david@xxxxxxxxxxxxx> <1263210599-25067-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Jan 11, 2010 at 10:49:58PM +1100, Dave Chinner wrote:
> Now that the AIL push algorithm is traversal safe, we don't need a
> watchdog function in the xfsaild to catch pushes that fail to make
> progress. Remove the watchdog timeout and make pushes purely driven
> by demand. This will remove the once-per-second wakeup that is seen
> when the filesystem is idle and make laptop power misers happy.
> 
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>