[Top] [All Lists]

Re: [PATCH] xfs: fix stale inode flush avoidance

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix stale inode flush avoidance
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 11 Jan 2010 16:47:33 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263210321-21068-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1263210321-21068-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Jan 11, 2010 at 10:45:21PM +1100, Dave Chinner wrote:
> When reclaiming stale inodes, we need to guarantee that inodes are
> unpinned before returning with a "clean" status. If we don't we can
> reclaim inodes that are pinned, leading to use after free in the
> transaction subsystem as transactions complete.

Looks good.  Per discussion this morning the clean check might not be
good enough for delwri buffers either, but as let's leave that for the
more throughout redo of the inode buffer flushing.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>