xfs
[Top] [All Lists]

Re: [PATCH 4/4] xfs: Remove inode iolock held check during allocation

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfs: Remove inode iolock held check during allocation
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 11 Jan 2010 05:20:55 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1263167508-9346-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1263167508-9346-1-git-send-email-david@xxxxxxxxxxxxx> <1263167508-9346-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Jan 11, 2010 at 10:51:48AM +1100, Dave Chinner wrote:
> lockdep complains about a the lock not being initialised as we do
> an ASSERT based check that the lock is not held before we initialise
> it to catch inodes freed with the lock held.
> 
> lockdep does this check for us in the lock initialisation code, so
> remove the ASSERT to stop the lockdep warning.

Yes, checking things on the lock before it's initialized is always a bad
idea.  I think this is my fault because I moved the iolock
initialization from the inode_init_always path into the inode_init_once
path.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>