Re: [PATCH 4/4] xfs: Remove inode iolock held check during allocation

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Mon, Jan 11, 2010 at 10:51:48AM +1100, Dave Chinner wrote:
> lockdep complains about a the lock not being initialised as we do
> an ASSERT based check that the lock is not held before we initialise
> it to catch inodes freed with the lock held.
> 
> lockdep does this check for us in the lock initialisation code, so
> remove the ASSERT to stop the lockdep warning.

Yes, checking things on the lock before it's initialized is always a bad
idea.  I think this is my fault because I moved the iolock
initialization from the inode_init_always path into the inode_init_once
path.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>