xfs
[Top] [All Lists]

[PATCH 4/4] xfs: Remove inode iolock held check during allocation

To: xfs@xxxxxxxxxxx
Subject: [PATCH 4/4] xfs: Remove inode iolock held check during allocation
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 11 Jan 2010 10:51:48 +1100
In-reply-to: <1263167508-9346-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1263167508-9346-1-git-send-email-david@xxxxxxxxxxxxx>
lockdep complains about a the lock not being initialised as we do
an ASSERT based check that the lock is not held before we initialise
it to catch inodes freed with the lock held.

lockdep does this check for us in the lock initialisation code, so
remove the ASSERT to stop the lockdep warning.

Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
---
 fs/xfs/xfs_iget.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c
index fa402a6..155e798 100644
--- a/fs/xfs/xfs_iget.c
+++ b/fs/xfs/xfs_iget.c
@@ -73,7 +73,6 @@ xfs_inode_alloc(
        ASSERT(atomic_read(&ip->i_pincount) == 0);
        ASSERT(!spin_is_locked(&ip->i_flags_lock));
        ASSERT(completion_done(&ip->i_flush));
-       ASSERT(!rwsem_is_locked(&ip->i_iolock.mr_lock));
 
        mrlock_init(&ip->i_iolock, MRLOCK_BARRIER, "xfsio", ip->i_ino);
 
-- 
1.6.5

<Prev in Thread] Current Thread [Next in Thread>