xfs
[Top] [All Lists]

[PATCH] xfstests: add test for ctimes updates in futimens

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfstests: add test for ctimes updates in futimens
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 10 Jan 2010 16:52:27 -0500
Cc: Eric Blake <ebb9@xxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
This adds Erik's testcase for the ctime update in futimes that I fixed
a while ago.

Erik, can you double check the attribution and licensing for your
testcase?


Index: xfstests-dev/src/Makefile
===================================================================
--- xfstests-dev.orig/src/Makefile      2010-01-10 21:44:41.000000000 +0000
+++ xfstests-dev/src/Makefile   2010-01-10 21:44:44.000000000 +0000
@@ -15,7 +15,8 @@ TARGETS = dirstress fill fill2 getpagesi
 LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize \
        preallo_rw_pattern_reader preallo_rw_pattern_writer ftrunc trunc \
        fs_perms testx looptest locktest unwritten_mmap \
-       bulkstat_unlink_test bulkstat_unlink_test_modified t_dir_offset
+       bulkstat_unlink_test bulkstat_unlink_test_modified t_dir_offset \
+       t_futimens
 
 ifeq ($(HAVE_XLOG_ASSIGN_LSN), true)
 LINUX_TARGETS += loggen
Index: xfstests-dev/src/t_futimens.c
===================================================================
--- /dev/null   1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/src/t_futimens.c       2010-01-10 21:44:44.000000000 +0000
@@ -0,0 +1,32 @@
+/*
+ * Check ctime updates when calling futimens without UTIME_OMIT for the
+ * mtime entry.
+ *
+ * Copyright (c) 2009 Eric Blake <ebb9@xxxxxxx>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2, or (at your option)
+ * any later version.
+ */
+#include <fcntl.h>
+#include <unistd.h>
+#include <stdio.h>
+#include <sys/stat.h>
+
+int
+main(int argc, char **argv)
+{
+       int fd = creat ("file", 0600);
+       struct stat st1, st2;
+       struct timespec t[2] = { { 1000000000, 0 }, { 0, UTIME_OMIT } };
+
+       fstat(fd, &st1);
+       sleep(1);
+       futimens(fd, t);
+       fstat(fd, &st2);
+
+       if (st1.st_ctime == st2.st_ctime)
+               printf("failed to update ctime!\n");
+       return 0;
+}
Index: xfstests-dev/221
===================================================================
--- /dev/null   1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/221    2010-01-10 21:44:44.000000000 +0000
@@ -0,0 +1,49 @@
+#! /bin/sh
+# FS QA Test No. 221
+#
+# Check ctime updates when calling futimens without UTIME_OMIT for the
+# mtime entry.
+#
+# Based on a bug report and testcase from Eric Blake <ebb9@xxxxxxx>.
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2010 Christoph Hellwig.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+# creator
+owner=hch@xxxxxx
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1       # failure is the default!
+
+# get standard environment, filters and checks
+. ./common.rc
+
+# real QA test starts here
+_supported_fs xfs
+_supported_os Linux
+
+echo "Silence is golden."
+
+(cd $TEST_DIR && $here/src/t_futimens)
+
+status=0
+exit $status
Index: xfstests-dev/221.out
===================================================================
--- /dev/null   1970-01-01 00:00:00.000000000 +0000
+++ xfstests-dev/221.out        2010-01-10 21:44:44.000000000 +0000
@@ -0,0 +1,2 @@
+QA output created by 221
+Silence is golden.
Index: xfstests-dev/group
===================================================================
--- xfstests-dev.orig/group     2010-01-10 21:44:41.000000000 +0000
+++ xfstests-dev/group  2010-01-10 21:44:44.000000000 +0000
@@ -330,3 +330,4 @@ prealloc
 218 auto fsr quick
 219 auto quota quick
 220 auto quota quick
+221 auto metadata quick

<Prev in Thread] Current Thread [Next in Thread>