xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: 219: ignore duplicates reported by repquota

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: 219: ignore duplicates reported by repquota
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 10 Jan 2010 16:18:21 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A6942@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A6942@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sun, Jan 10, 2010 at 01:26:32PM -0600, Alex Elder wrote:
> (Re-sending; I misaddressed it the first time.)
> 
> Arrange to ignore duplicate entries reported by the repquota command.
> This can happen if an id is used more than once (such as when two user
> names are assigned the same uid).
> 
> Do this here by simply dropping any reported entries whose id number
> has already been seen in the output.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>
> 
> ---
>  219 |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: b/219
> ===================================================================
> --- a/219
> +++ b/219
> @@ -85,7 +85,8 @@ test_accounting()
>               $here/src/lstat64 $file | head -3 | filter_scratch
>       done
>  
> -     repquota -$type -s -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch
> +     repquota -$type -s -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
> +     awk '/^#/ { if (! seen[$1]) { seen[$1]++; next; } } { print }'

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>