[Top] [All Lists]

Re: Re: [PATCH v2] xfs: Don't flush stale inodes

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: Re: [PATCH v2] xfs: Don't flush stale inodes
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 10 Jan 2010 09:39:20 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A693B@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20100109000927.GE8654@xxxxxxxxxxxxxxxx> <1AB9A794DBDDF54A8A81BE2296F7BDFE012A693B@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Jan 09, 2010 at 10:22:14AM -0600, Alex Elder wrote:
> Yes, I see that now.  I had marked your older one "Reviewed" and
> didn't look further.  I will re-do the port and will re-submit.
> BTW I also plan to port the perag radix tree patch(es) over this
> for you after I get this one published.

Don't make extra work for yourself that slows down the rate at which
you can merge stuff. When the tree is updated with these patches,
I'll fix any conflicts in my patches and retest them, then send them
to the list again.

As a maintainer, manually munging a bunch patches around to fit,
then asking if they are correct, then finally merging them doesn't
scale - push that work back out to the patch authors where it does
scale and who have probably already done the work.... ;)


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>