xfs
[Top] [All Lists]

Re: [PATCH, updated] xfs: Ensure we force all busy extents in range to

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH, updated] xfs: Ensure we force all busy extents in range to disk
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 9 Jan 2010 14:35:14 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A693C@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20100109000927.GE8654@xxxxxxxxxxxxxxxx> <1AB9A794DBDDF54A8A81BE2296F7BDFE012A693C@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

>  TRACE_EVENT(xfs_alloc_busysearch,
>       TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno,
> -              xfs_extlen_t len, int found),
> -     TP_ARGS(mp, agno, agbno, len, found),
> +              xfs_extlen_t len, int found, xfs_lsn_t lsn),
> +     TP_ARGS(mp, agno, agbno, len, found, lsn),

The found argument to this tracepoint can be dropped - with the new loop
style it doesn't work anymore, and a non-zero lsn provides the same
information.

<Prev in Thread] Current Thread [Next in Thread>