xfs
[Top] [All Lists]

Re: [GIT PULL] XFS update for 2.6.33-rc1

To: "Alex Elder" <aelder@xxxxxxx>
Subject: Re: [GIT PULL] XFS update for 2.6.33-rc1
From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Date: Fri, 8 Jan 2010 09:44:28 -0800
Cc: "Dave Chinner" <david@xxxxxxxxxxxxx>, <torvalds@xxxxxxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A687F@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Organization: Oracle Linux Eng.
References: <20091217002007.GF4850@xxxxxxxxxxxxxxxx> <1AB9A794DBDDF54A8A81BE2296F7BDFE012A687F@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
On Wed, 16 Dec 2009 21:41:12 -0600 Alex Elder wrote:

> Dave Chinner wrote:
> > On Wed, Dec 16, 2009 at 01:55:12PM -0800, Randy Dunlap wrote:
> >> On Wed, 16 Dec 2009 15:26:10 -0600 Alex Elder wrote:
> >> 
> >>> One more XFS update for -rc1, now that the new XFS tracing code has
> >>> been committed.
> >> 
> >> Sorry if I have missed it, but have the printk format warnings
> >> on i386 builds been fixed?
> > 
> > I don't see any here w/ gcc 4.3.4 x86-64 compiling i386 kernels....
> 
> I didn't get them either when I built in my environment.
> 
> Dave, your patch looks good to me, and Randy has acked it
> so I'm going to pull it into our XFS top-of-tree.  I'll
> hold off sending yet another pull request to Linus for
> now.  Thanks for addressing it quickly.
> 
>                                       -Alex

Hi Alex,
Dave's patch is now needed in Linus's mainline kernel tree...


> > /me hates gcc's warning inconsistencies with a passion.
> > 
> >> e.g.:
> >> 
> >> In file included from linux-next-20091216/include/trace/ftrace.h:398,
> >>                  from linux-next-20091216/include/trace/define_trace.h:69,
> >>                  from 
> >> linux-next-20091216/fs/xfs/linux-2.6/xfs_trace.h:1369,
> >>                  from linux-next-20091216/fs/xfs/linux-2.6/xfs_trace.c:75:
> >> linux-next-20091216/fs/xfs/linux-2.6/./xfs_trace.h: In function
> >> 'ftrace_raw_output_id_xfs_iomap_enter': 
> >> linux-next-20091216/fs/xfs/linux-2.6/./xfs_trace.h:830:
> >> warning: format '%llx' expects type 'long long unsigned int', but argument 
> >> 12 has type
> >> 'xfs_fsblock_t'  
> > 
> > Patch that should fix this below.
> > 
> > Cheers,
> > 
> > Dave.


---
~Randy

<Prev in Thread] Current Thread [Next in Thread>