On Wed, Jan 06, 2010 at 01:08:00PM -0500, Christoph Hellwig wrote:
> Btw, after this series XFS_IFLUSH_DELWRI_ELSE_SYNC is also unused,
> might be worth to throw something like the patch below in to clean
> up xfs_iflush:
Yes, makes sense. I'll add the patch to my QA series after updating
it for the slight changes to the unmount reclaim I ahd in the
second posting of the patch. Can I get a signoff from you for this?
> I'm also not sure we do enough of the noblock calls either with or
> without your series. There seem to be a lot more non-blocking sync
> calls than iflush calls.
I don't quite follow - inode flushes from the bdi threads should be
the majority of flushes (i.e. from xfs_fs_write_inode()) and they
are non-blocking. the xfssyncd does delwri writeback (maybe that
should be non-blocking and then we can get rid of that flag, too),
so the only sync inode writeback path is from xfs_fs_write_inode()
for sync flushing, as well as the unmount reclaim path....