xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add another fallocate test to 214

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add another fallocate test to 214
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Jan 2010 11:49:44 -0500
Cc: xfs mailing list <xfs@xxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>
In-reply-to: <4B427731.9080801@xxxxxxxxxx>
References: <4B427731.9080801@xxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Jan 04, 2010 at 05:18:09PM -0600, Eric Sandeen wrote:
> ext4 had a regression where it double-accounted used blocks
> if you fallocated on top of delalloc blocks.  Ted sent a
> c program to exploit it (see "fsstress-induced corruption reproduced"
> on linux-ext4 on 12/31/2009) and it's trivial to do the same thing
> within the xfstests framework using xfs_io.
> 
> This also changes the handcrafted xfs_io tests to use the
> _require_xfs_io_falloc helper, not sure how that got missed.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>