xfs
[Top] [All Lists]

Re: [PATCH V3] sort: Introduce generic list_sort function

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH V3] sort: Introduce generic list_sort function
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Tue, 5 Jan 2010 13:52:35 +0100
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Artem Bityutskiy <dedekind@xxxxxxxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Adrian Hunter <adrian.hunter@xxxxxxxxx>
In-reply-to: <20100105122101.GR13802@xxxxxxxxxxxxxxxx>
References: <1262649295-28427-1-git-send-email-david__25057.2445955642$1262651404$gmane$org@xxxxxxxxxxxxx> <87eim4dbzw.fsf@xxxxxxxxxxxxxxxxx> <20100105122101.GR13802@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
> > Also it would seem cleaner to have it in a own file.
> 
> That might make sense if we had a large number of generic sort
> functions and it was difficult to tell the code apart, but we've
> only got 2 right now....

I was more thinking of the case that it can be easily made a lib-y
and then eliminated by the linker on non modular kernels if not needed
(unfortunately that would require putting the EXPORT_SYMBOL somewhere else)

-Andi

<Prev in Thread] Current Thread [Next in Thread>