| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/3] XFS: Sort delayed write buffers before dispatch |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 5 Jan 2010 10:53:09 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20100104154331.GA7924@xxxxxxxxxxxxx> |
| References: | <1262401416-19546-1-git-send-email-david@xxxxxxxxxxxxx> <1262401416-19546-4-git-send-email-david@xxxxxxxxxxxxx> <20100104154331.GA7924@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Mon, Jan 04, 2010 at 10:43:31AM -0500, Christoph Hellwig wrote: > On Sat, Jan 02, 2010 at 02:03:36PM +1100, Dave Chinner wrote: > > Ideally this should use a list sort rather than requiring an > > external buffer to sort the buffers in, but for simplicity > > just do it via sort function. Followup patches are needed to > > take the list sort functions from the DRM and UBIFS code and > > make it a common function and to utilise it. That will allow > > sorting the entire delwri queue to be written in one go. > > > Maybe getting the common list sort in ASAP might be a good idea. That > way we could have it ready by the time this patchset is merged. If not > adding a new list sort to XFS temporarily might be a better idea than > artifically flattening the list. I'm about to post that and an updated patch series to use it. ;) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] XFS: Don't wake xfsbufd when idle, Dave Chinner |
|---|---|
| Next by Date: | [PATCH] sort: Introduce generic list_sort function, Dave Chinner |
| Previous by Thread: | Re: [PATCH 3/3] XFS: Sort delayed write buffers before dispatch, Christoph Hellwig |
| Next by Thread: | [PATCH 1/3] XFS: Use delayed write for inodes rather than async, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |