xfs
[Top] [All Lists]

Re: [PATCH 3/3] XFS: Sort delayed write buffers before dispatch

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] XFS: Sort delayed write buffers before dispatch
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 4 Jan 2010 10:43:31 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1262401416-19546-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1262401416-19546-1-git-send-email-david@xxxxxxxxxxxxx> <1262401416-19546-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Jan 02, 2010 at 02:03:36PM +1100, Dave Chinner wrote:
> Ideally this should use a list sort rather than requiring an
> external buffer to sort the buffers in, but for simplicity
> just do it via sort function. Followup patches are needed to
> take the list sort functions from the DRM and UBIFS code and
> make it a common function and to utilise it. That will allow
> sorting the entire delwri queue to be written in one go.


Maybe getting the common list sort in ASAP might be a good idea.  That
way we could have it ready by the time this patchset is merged.  If not
adding a new list sort to XFS temporarily might be a better idea than
artifically flattening the list.

<Prev in Thread] Current Thread [Next in Thread>