Re: [PATCH] XFS: Don't flush stale inodes

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] XFS: Don't flush stale inodes
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sat, 2 Jan 2010 08:17:01 -0500
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20100102122405.GI13802@xxxxxxxxxxxxxxxx>
References:	<1262399980-19277-1-git-send-email-david@xxxxxxxxxxxxx> <20100102120053.GB18502@xxxxxxxxxxxxx> <20100102122405.GI13802@xxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

This looks like a bigger problem to me.  We only mark inodes as stale
from xfs_ifree_cluster, which via xfs_ifree and xfs_inactive gets
called from xfs_fs_clear_inode.  Given that the inode has now been
deleted we should not mark it as reclaimable in xfs_fs_destroy_inode
but go on to reap it given that there is nothing to reclaim.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] XFS: Don't flush stale inodes, Dave Chinner Re: [PATCH] XFS: Don't flush stale inodes, Christoph Hellwig Re: [PATCH] XFS: Don't flush stale inodes, Dave Chinner Re: [PATCH] XFS: Don't flush stale inodes, Dave Chinner Re: [PATCH] XFS: Don't flush stale inodes, Christoph Hellwig <= Re: [PATCH] XFS: Don't flush stale inodes, Dave Chinner RE: [PATCH] XFS: Don't flush stale inodes, Alex Elder [PATCH v2] xfs: Don't flush stale inodes, Alex Elder Re: [PATCH v2] xfs: Don't flush stale inodes, Dave Chinner RE: Re: [PATCH v2] xfs: Don't flush stale inodes, Alex Elder Re: Re: [PATCH v2] xfs: Don't flush stale inodes, Dave Chinner RE: Re: [PATCH v2] xfs: Don't flush stale inodes, Alex Elder [PATCH, updated] xfs: Ensure we force all busy extents in range to disk, Alex Elder Re: [PATCH, updated] xfs: Ensure we force all busy extents in range to disk, Christoph Hellwig RE: [PATCH, updated] xfs: Ensure we force all busy extents inrange to disk, Alex Elder

Previous by Date:	Re: [PATCH 3/3] XFS: Sort delayed write buffers before dispatch, Andi Kleen
Next by Date:	Re: [PATCH] XFS: Don't flush stale inodes, Dave Chinner
Previous by Thread:	Re: [PATCH] XFS: Don't flush stale inodes, Dave Chinner
Next by Thread:	Re: [PATCH] XFS: Don't flush stale inodes, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]