[Top] [All Lists]

Re: [PATCH] XFS: Don't flush stale inodes

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: Don't flush stale inodes
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 2 Jan 2010 08:17:01 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100102122405.GI13802@xxxxxxxxxxxxxxxx>
References: <1262399980-19277-1-git-send-email-david@xxxxxxxxxxxxx> <20100102120053.GB18502@xxxxxxxxxxxxx> <20100102122405.GI13802@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
This looks like a bigger problem to me.  We only mark inodes as stale
from xfs_ifree_cluster, which via xfs_ifree and xfs_inactive gets
called from xfs_fs_clear_inode.  Given that the inode has now been
deleted we should not mark it as reclaimable in xfs_fs_destroy_inode
but go on to reap it given that there is nothing to reclaim.

<Prev in Thread] Current Thread [Next in Thread>