[Top] [All Lists]

Re: [PATCH] XFS: Kill filestreams cache flush

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: Kill filestreams cache flush
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 2 Jan 2010 07:46:49 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100102121203.GG13802@xxxxxxxxxxxxxxxx>
References: <1262399900-19110-1-git-send-email-david@xxxxxxxxxxxxx> <20100102115338.GA18502@xxxxxxxxxxxxx> <20100102121203.GG13802@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Jan 02, 2010 at 11:12:03PM +1100, Dave Chinner wrote:
> Which means that sync destroys active filestreams associations and
> that seems more broken to me than anything an active reference will
> cause. I think just letting them time out is better than having them
> destroyed by external operations. I'm happy to leave it there if you
> want....

Just trying to understand what's going on here.  If you think the new
behaviour is better and it doesn't cause any regressions in QA I'm fine
with it.  Consider it:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>